-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes from PR 381 #443
Conversation
ps @krnowak if you let maintainers edit your branches, it makes it easier to get things synced and promptly merged :) |
Would love to, but for some reason this option not accessible for me neither here nor in PR creation page… |
Likely an org setting, try asking Kinvolk admins if they'll turn that option in in your repo |
I asked the admins, they couldn't find anything in neither org settings nor in repo settings. Heck, I even cloned opentelemetry-go to my own test org to figure it out, but I also couldn't find it nor the option was available to me. I also cloned opentelemetry-go to my personal account and the "allow edits from maintainers" option was available. So I suppose that this option is only available for PRs made from the repos in personal accounts. |
Unused. And confusing, since "ot" may mean "opentracing" as well.
No need for a block.
a0f1bec
to
e695cd1
Compare
Rebased. |
These are some fixes I found in #381. This PR is to shrink #381 a bit.